Re: [PATCH 5/5] [GSOC] ref-filter: add %(rest) atom
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Jul 23, 2021, 14:11 UTC
- Message-ID
- <CAOLTT8Q1A8FBiWdEqF90_yQfT11uE3OwRy-2MGV9qm-4O4S1QQ@mail.gmail.com>
- In-Reply-To
- <CA+P7+xr7GCZCk44e_CSYFDr_ow3-BBMUfP5t6=cErFBES4N8+Q@mail.gmail.com>
Jacob Keller <jacob.keller@gmail.com> 于2021年7月23日周五 下午5:09写道:
Show 17 quoted lines
> > On Thu, Jul 22, 2021 at 12:40 AM ZheNing Hu via GitGitGadget > <gitgitgadget@gmail.com> wrote: > > > > From: ZheNing Hu <adlternative@gmail.com> > > > > In order to let "cat-file --batch=%(rest)" use the ref-filter > > interface, add %(rest) atom for ref-filter. Introduce the > > reject_atom() to reject the atom %(rest) for "git for-each-ref", > > "git branch", "git tag" and "git verify-tag". > > > > To a reader intimately familiar with cat-file, %(rest) might be > obvious.. but it would help the commit message read more easily if > there was a short explanation of what %(rest) did. It is not obvious > just from the name to me. >
You are right, I may subconsciously think that everyone knows the %(rest) in cat-file. I will change it.
> Thanks, > Jake
Thanks. -- ZheNing Hu