git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] oss-fuzz: set a gitdir in the commit-graph fuzzer

From
SJSami Jawhar <sami@theorem.dev>
Date
Oct 24, 2026, 18:50 UTC
Message-ID
<CAOJ8FdeyJp4ZOfp99DBSp4brWzngdqzrkSY36ByEh=4UPw28Mg@mail.gmail.com>

Since f1141b4391 (commit-graph: refactor `parse_commit_graph()` to take a repository, 2025-08-15), parse_commit_graph() calls prepare_repo_settings().

The fuzzer sets settings.initialized, so that git reads no configuration. But prepare_repo_settings() checks for a gitdir before it reads that flag, and the repository of the fuzzer has no gitdir. Thus each input that passes the header and the three required chunks stops at

    BUG: repo-settings.c:40: Cannot add settings for uninitialized repository

The fuzzer never reaches the code that reads the optional chunks: generation data and changed-path Bloom filters.

Set a placeholder gitdir, as test-path-utils does. prepare_repo_settings() checks only that the gitdir is not NULL. It then returns, because the fuzzer marks the settings as initialized. repo_clear() frees the gitdir, and no code opens a file under it.

Signed-off-by: Sami Jawhar <sami@theorem.dev>
---
 oss-fuzz/fuzz-commit-graph.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/oss-fuzz/fuzz-commit-graph.c b/oss-fuzz/fuzz-commit-graph.c
index 59bbb84..9a226eb 100644
--- a/oss-fuzz/fuzz-commit-graph.c
+++ b/oss-fuzz/fuzz-commit-graph.c
@@ -20,6 +20,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
 	 * possible.
 	 */
 	repo_set_hash_algo(the_repository, GIT_HASH_SHA1);
+	the_repository->gitdir = xstrdup(".git");
 	the_repository->settings.initialized = 1;
 	the_repository->settings.commit_graph_generation_version = 2;
 	the_repository->settings.commit_graph_changed_paths_version = 1;
Next: Patrick Steinhardt
Message 1 of 2 in “oss-fuzz: set a gitdir in the commit-graph fuzzer”
  1. oss-fuzz: set a gitdir in the commit-graph fuzzerSami Jawhar, Oct 24, 2026
  2. Patrick SteinhardtOct 29, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.