git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/6][GSoC] iterate dirs before or after their contents

From
PKPlato Kiorpelidis <kioplato@gmail.com>
Date
Apr 19, 2022, 13:06 UTC
Message-ID
<CAO2gv81bM2srW0jxFwYQQ6xbt3ZrExNjf7_Y2Dxyfydc71r27w@mail.gmail.com>
In-Reply-To
<df287d4f-e9da-4ce0-d7e9-1b1fe7671aab@gmail.com>
On Mon, Apr 11, 2022 at 4:37 PM Phillip Wood <phillip.wood123@gmail.com> wrote:
>
> Hi Plato
Hey Phillip,

Thanks for reviewing my patches, your input is welcomed! :) I'll reply your reviews and Ævar's in the following days. I need some time to read dir-iterator again in combination with your comments.

Show 6 quoted lines
>
> I think this would be a useful addition to git, thanks for working on
> it. I've left some comments on the individual patches. In general I
> think this series would benefit from trying to work with the existing
> code and change one aspect at a time in stages rather than rewriting
> large chunks all at once.

Agreed, I'll change one aspect at a time. First, I'll include suggested changes from this version and also convert entry.c to use dir-iterator instead of opendir, readdir, closedir API and submit v2. Then I'll spend some time understanding read_directory_recursive() and search for possible parts that can be cleaned up using dir-iterator. I'll compile a set of possible customer candidates for dir-iterator as reference. This will take some time since I'll prepare for the upcoming GSoC as a possible contributor.

Thanks, Plato

Show 7 quoted lines
>
> Best Wishes
>
> Phillip
>
> On 10/04/2022 12:18, Plato Kiorpelidis wrote:
> [...]
Previous: Phillip Wood
Message 22 of 22 in “[GSoC] iterate dirs before or after their contents”
  1. 0/6 [GSoC] iterate dirs before or after their contentsPlato Kiorpelidis, Apr 10, 2022
  2. 1/6 t0066: improve readablity of dir-iterator testsPlato Kiorpelidis, Apr 10, 2022
  3. Phillip WoodApr 11, 2022
  4. Plato KiorpelidisApr 24, 2022
  5. 2/6 t0066: better test coverage for dir-iteratorPlato Kiorpelidis, Apr 10, 2022
  6. 3/6 dir-iterator: refactor dir_iterator_advance()Plato Kiorpelidis, Apr 10, 2022
  7. Ævar Arnfjörð BjarmasonApr 11, 2022
  8. Phillip WoodApr 11, 2022
  9. Plato KiorpelidisApr 27, 2022
  10. Phillip WoodApr 11, 2022
  11. Plato KiorpelidisApr 27, 2022
  12. 5/6 t0066: remove redundant testsPlato Kiorpelidis, Apr 10, 2022
  13. Ævar Arnfjörð BjarmasonApr 11, 2022
  14. Plato KiorpelidisApr 27, 2022
  15. 4/6 dir-iterator: iterate dirs before or after their contentsPlato Kiorpelidis, Apr 10, 2022
  16. Phillip WoodApr 11, 2022
  17. Plato KiorpelidisApr 27, 2022
  18. 6/6 test-dir-iterator: handle EACCES errno by dir-iteratorPlato Kiorpelidis, Apr 10, 2022
  19. Ævar Arnfjörð BjarmasonApr 11, 2022
  20. Plato KiorpelidisApr 27, 2022
  21. Phillip WoodApr 11, 2022
  22. Plato KiorpelidisApr 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.