Re: [PATCH 21/21] t3080: tests for git-list-files

From

Michael Blume <blume.mike@gmail.com>

Date

Jan 28, 2015, 04:44 UTC

Message-ID

<CAO2U3QhA1bGAKmM4OL0VVuOfwaocqmFEsQdZNhSqf_7tkJ+=WQ@mail.gmail.com>

In-Reply-To

<CAPig+cQ8AuoA=ZNaOiZ_JQb-fKtXa-mFhoYQg+eWJxF3eFy9FA@mail.gmail.com>

Test 3 is failing on my mac:

@@ -1,3 +1,3 @@
-dir
-file
-gitlink
+dir
+file
+gitlink
not ok 3 - color.ls.*
#
# test_config color.ls.file red &&
# test_config color.ls.directory green &&
# test_config color.ls.submodule yellow &&
# git list-files --color=always >actual &&
# test_cmp "$TEST_DIRECTORY"/t3080/color_ls actual
#

On Sun, Jan 25, 2015 at 11:20 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sun, Jan 25, 2015 at 7:37 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> diff --git a/t/t3080-list-files.sh b/t/t3080-list-files.sh
>> new file mode 100755
>> index 0000000..6313dd9
>> --- /dev/null
>> +++ b/t/t3080-list-files.sh
>> +test_expect_success 'no dups' '
>> +       echo dirty >>file &&
>
> To leave a clean slate for subsequent tests, would it make sense to
> restore 'file' to a clean state via test_when_finished()?
>
>> +       git list-files -m file >actual &&
>> +       echo "file" >expected &&
>> +       test_cmp expected actual &&
>> +       git list-files -cm file >actual &&
>> +       echo "C file" >expected &&
>> +       test_cmp expected actual &&
>> +       git list-files -tcm file >actual &&
>> +       test_cmp expected actual
>> +'
>> +
>> +test_expect_success 'diff-cached' '
>> +       echo dirty >>file &&
>> +       git add file &&
>
> Ditto here?
>
>> +       git list-files -M >actual &&
>> +       echo "file" >expected &&
>> +       test_cmp expected actual
>> +'
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html