git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: rebase -i: quick/inline reword

From
Solomon Ucko <solly.ucko@gmail.com>
Date
May 7, 2020, 14:01 UTC
Message-ID
<CANtMP6pSgU2WfuHVug-dj=10LNOL-mLL-5rTio=q3GjUs5MrgQ@mail.gmail.com>
In-Reply-To
<xmqqzhak4a9o.fsf@gitster.c.googlers.com>
On Thu, May 7, 2020 at 12:52 AM Junio C Hamano <gitster@pobox.com> wrote:
> It is probably a bad idea, as it encourages a single-liner commit
> message without any body.

You could modify the title and keep the rest of the message. You could display the modified message similarly to how `reword` does, to allow modifying the rest of the message.

Show 7 quoted lines
> Besides, neither is really workable, as the single line text after
> the abbreviated commit object name in the todo list is meant as an
> output only "informational" comment on each step, and there are
> plans to add more than just the squashed title paragraph there
> (cf. *1* for an example).  Even without such a future change, the
> material there may not be just the commit title, if I am reading
> the code correctly, when rebase.instructionFormat is in use.

You could have some sort of separator between the title and the rest of the info. You could disable the extra info when using this mode, if it's a command-line flag. You could require the title to be at the end to use this feature, possibly after some sort of start marker.

Solomon Ucko
Previous: Sergey OrganovNext: Sergey Organov
Message 5 of 13 in “rebase -i: quick/inline reword”
  1. Solomon UckoMay 7, 2020
  2. Junio C HamanoMay 7, 2020
  3. Jeff KingMay 7, 2020
  4. Sergey OrganovMay 7, 2020
  5. Solomon UckoMay 7, 2020
  6. Sergey OrganovMay 7, 2020
  7. brian m. carlsonMay 8, 2020
  8. Sergey OrganovMay 8, 2020
  9. Johannes AltmanningerAug 16, 2020
  10. Junio C HamanoAug 16, 2020
  11. Sergey OrganovAug 16, 2020
  12. Junio C HamanoAug 16, 2020
  13. Sergey OrganovAug 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.