Re: "gitk --author=foo" shows also parent

From: Mike Rappazzo <rappazzo@gmail.com>
Date: Apr 26, 2016, 14:06 UTC
Message-ID: <CANoM8SXn0CgUqQU3vmH-kwuxiDfC1=4FCh1SUsYuOOv4fQtWpw@mail.gmail.com>
In-Reply-To: <571F6852.1070405@qt.io>

On Tue, Apr 26, 2016 at 9:08 AM, Nikolai Kosjar <nikolai.kosjar@qt.io> wrote:

Show 10 quoted lines

> Hi!
>
>         $ gitk --author=foo
>
> ...seems to show also the parent of each author-matched commit, whereas
>
>         $ git log --author=foo
>
> does not. Is this intended or a bug? I've stumbled over this while
> configuring a gitk view with the author field.

I believe that this is intentional. Notice that the parent commit's circle is just outlined compared to the selected authored commits are filled. I consider this the context of the commits you are looking at.

Show 34 quoted lines

>
> Nikolai
>
>
>
>
>
> # Setup
> ~/work/gitkBug % git init .
> ~/work/gitkBug % touch file1 file2
> ~/work/gitkBug % git add file1
> ~/work/gitkBug % git commit "--author=MrFoo <foo@world>" file1 -m "add
> file1"
> ~/work/gitkBug % git add file2
> ~/work/gitkBug % git commit "--author=MrBar <bar@world>" file2 -m "add
> file2"
>
> # TEST: git log --author - OK
> ~/work/gitkBug % git log --author=MrBar # OK, as expected
> commit 8aa4a4f651162bcb2275a1e9ee23fc1bb7226097
> Author: MrBar <bar@world>
> Date:   Tue Apr 26 14:22:58 2016 +0200
>
>     add file2
>
> # TEST: gitk --author - OPS
> ~/work/gitkBug % gitk --author=MrBar  # Ops, gitk shows also the parent
> commit
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html