Re: [PATCH gitk] gitk: add README.md with contribution guidelines

From: Mike Rappazzo <rappazzo@gmail.com>
Date: Aug 20, 2025, 21:20 UTC
Message-ID: <CANoM8SX7_uQV-ZRAim55UaiHYCKTgKN0AO6zB1O7Ux4deiCNaw@mail.gmail.com>
In-Reply-To: <xmqqldnd8zpc.fsf@gitster.g>

On Wed, Aug 20, 2025 at 5:12 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 28 quoted lines

>
> Mike Rappazzo <rappazzo@gmail.com> writes:
>
> > On Wed, Aug 20, 2025 at 4:57 PM Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >> Michael Rappazzo <rappazzo@gmail.com> writes:
> >>
> >> > +#### Creating and Sending Patches
> >> > +After committing your changes:
> >> > +```bash
> >> > +git format-patch -1 --subject-prefix="PATCH gitk"
> >> > +git send-email --to=git@vger.kernel.org --cc=j6t@kdbg.org *.patch
> >> > +```
> >>
> >> Just being curious, but does the project strongly discourage a
> >> multi-patch topic?
> >
> > I don't believe so.  I think most people know how to submit a github
> > PR, but J6t has mentioned that he prefers the mailing list (as noted
> > in the readme).  So I wrote a simple example to show that patching by
> > email doesn't have to be scary.
>
> As the original assumes that you are on the branch where you are
> taking the patch(es) from, perhaps
>
>     $ git format-patch --subject-prefix='PATCH gitk' @{u}..
>
> would work?  I was mostly reacting to the "-1" on the command line.

`@{u}..` is funny, because that seems to assume that you haven't pushed your changes to its upstream yet. I could say `master..` but that assumes that you named the branch that (as opposed to `main` or something). I will try a few different ways and see how they feel. As I said, I just wanted an example to demystify patching by email. I think if I add something above to clarify that this is just an example and not verbose instructions it could help too.

Show 7 quoted lines

>
> >> It would be really nice if you add "review them here before you run
> >> send-email" step between these two commands ;-).
> >
> > I can revise.  I will wait for more comments before sending a v2.
>
> Thanks.