Re: [PATCH v2] gitk: add README with usage, build, and contributing details

From: Mike Rappazzo <rappazzo@gmail.com>
Date: Aug 22, 2025, 19:55 UTC
Message-ID: <CANoM8SW_3dLtQBEcK=NgQWCezj2PNbokDyeaUvVMTN1ufYav_w@mail.gmail.com>
In-Reply-To: <cef6487f-aab4-421e-ba04-a5613c12e552@kdbg.org>

On Fri, Aug 22, 2025 at 2:27 PM Johannes Sixt <j6t@kdbg.org> wrote:

Show 14 quoted lines

> > +
> > +### Installation
> > +To install system-wide, you can use either `make` or `meson`:
> > +
> > +```bash
> > +# Using Make
> > +make install
>
> This doesn't install system-wide, but in $HOME/bin. I am unsure whether
> we should encourage this. AFAIC, I would be upset if this works without
> sudo *and* clutters my $HOME. (I pull Gitk into the Git repository,
> which I have patched to install in /usr/local.)
>
> How do Gitk contributors handle `make install`?

Maybe I should expand on this section and add details: ``` # Install to default location ($HOME/bin) make install

# Install to system-wide location sudo make install prefix=/usr/local

# Install to custom location make install prefix=/opt/gitk ```

Show 10 quoted lines

>
> > +
> > +# Using Meson
> > +meson setup builddir
> > +meson compile -C builddir
> > +meson install -C builddir
> > +```
>
> I haven't used the Meson infrastructure ever. I trust this procedure works.
>

Yes, I installed `meson` and ran these steps. It replaced my previously installed version

I'll send a new revision in a day or two.

Thanks for the look, _Mike