Re: [PATCH v3] worktree: add 'list' command

From: Mike Rappazzo <rappazzo@gmail.com>
Date: Aug 11, 2015, 11:42 UTC
Message-ID: <CANoM8SUznDcZyH6-O9W2ZS7mwwevUz5ZwX4L_fVFV1cgRrF5xA@mail.gmail.com>
In-Reply-To: <1439261725.5283.9.camel@twopensource.com>

On Mon, Aug 10, 2015 at 10:55 PM, David Turner <dturner@twopensource.com> wrote:

Show 13 quoted lines

> On Mon, 2015-08-10 at 16:53 -0400, Michael Rappazzo wrote:
>> +                     while ((d = readdir(dir)) != NULL) {
>
> I think it would be useful to break this loop out into a
> for_each_worktree function.
>
> While looking into per-worktree ref stuff, I have just noticed that git
> prune will delete objects that are only referenced in a different
> worktree's detached HEAD.  To fix this, git prune will need to walk over
> each worktree, looking at that worktree's HEAD (and other per-worktree
> refs).  It would be useful to be able to reuse some of this code for
> that task.
>

I agree, but I will save that for another round.