git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Bug] git rev-parse --git-common-dir executed from a sub dir of the main worktree is wrong

From
Mike Rappazzo <rappazzo@gmail.com>
Date
Mar 28, 2016, 19:43 UTC
Message-ID
<CANoM8SU4ZWA=f1TSmNbHDBut7ox6cCVoi3K37GEmjHvygw1odg@mail.gmail.com>

I found a case where it seems that the result of `git rev-parse --git-common-dir` is incorrect. If you execute the command from within a subdirectory in the main worktree, it returns the path from the root of the worktree to the current dir + "/.git". (As a refresher, running this command from the root of the worktree returns ".git").

I wrote a quick test to demonstrate the problem:
+test_expect_success 'git-common-dir inside sub-dir' '
+   (
+ mkdir -p path/to/child &&
+ cd path/to/child &&
+ echo "$(git rev-parse --show-toplevel)/.git" >expected &&
+ git rev-parse --git-common-dir >actual &&
+ test_cmp expected actual
+ )
+'
+

I suggest that we change the result of this call to _always_ return an absolute path. I would be willing to code this change, but I didn't want to start anything that may be considered backwards-incompatible.

This seems related to [1]http://thread.gmane.org/gmane.comp.version-control.git/286038

Next: Junio C Hamano
Message 1 of 2 in “[Bug] git rev-parse --git-common-dir executed from a sub dir of the main worktree is wrong”
  1. Mike RappazzoMar 28, 2016
  2. Junio C HamanoMar 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.