Re: [PATCH 1/2] git-svn: use POSIX::sigprocmask to block signals

From: Roman Kagan <rkagan@mail.ru>
Date: Apr 11, 2012, 11:22 UTC
Message-ID: <CANiYKX56EnCJu6qTEJC=K7HVquObDXYCxRCPxn2YuJk+MZDmBQ@mail.gmail.com>
In-Reply-To: <20120410211120.GA27555@dcvr.yhbt.net>

11 апреля 2012 г. 1:11 пользователь Eric Wong <normalperson@yhbt.net> написал:

Show 5 quoted lines

> Roman Kagan <rkagan@mail.ru> wrote:
>> +             my $signew = POSIX::SigSet->new(SIGINT, SIGHUP, SIGTERM,
>> +                     SIGALRM, SIGPIPE, SIGUSR1, SIGUSR2);
>
> Considering your 2/2 patch, can we remove SIGPIPE here?

Doing it in this patch (i.e. before SIGPIPE gets ignored by the second patch) would be illogical.

I can submit another patch which removes SIGPIPE from the list of blocked signals (the reason would be mostly aesthetic since blocking an ignored signal is harmless anyway).

Roman.