Re: [PATCH] git-p4: import utf16 file properly
- From
- Chris Li <git@chrisli.org>
- Date
- Sep 14, 2011, 18:39 UTC
- Message-ID
- <CANeU7QnPqJ+igcmS1JX_vasCXr+Wpcx2b4Z-sy_=0qKEkG+v_w@mail.gmail.com>
- In-Reply-To
- <CANeU7QnW5kSni0W9M9q-FTWv4p_qc67LG3mA6BQj_U-wxNuZeQ@mail.gmail.com>
On Wed, Sep 14, 2011 at 11:29 AM, Chris Li <git@chrisli.org> wrote:
>> Does this change do the right thing with RCS keywords in UTF16 files? > > I don't know what is the rules about the RCS keyword in UTF16 files.
I did a little bit research and found this:
http://www.perforce.com/perforce/doc.current/manuals/p4guide/ab_filetypes.html
RCS keyword expand should only happen for "+k" or "+ko" modifiers. There for, "utf16" files without modifier should not be converted. In that regard, the patch is correct. But both the original and patched version did not handle "utf16+k" type of files. I still consider it as a separate issue.
Chris