Re: [PATCH] object-info: init request_info before reading arg
- From
Jiang Xin <worldhello.net@gmail.com>
- Date
- Apr 4, 2023, 01:07 UTC
- Message-ID
- <CANYiYbHB9AMpahiULEF=PoVG6y_ogDvVQvWY=ThKUdERmVbQyg@mail.gmail.com>
- In-Reply-To
- <xmqqsfdg7wif.fsf@gitster.g>
On Tue, Apr 4, 2023 at 12:36 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> > Jiang Xin <worldhello.net@gmail.com> writes: > > > From: Jiang Xin <zhiyou.jx@alibaba-inc.com> > > > > When retrieving object info via capability "object-info", we store the > > command args into a requested_info variable, but forget to initialize > > it. Initialize the variable before use to prevent unexpected output. > > Good eyes. We read the request packets to decide if we want to flip > the .size member of the structure, but the result would not make > much sense if the structure starts with a random garbage in it. > > I wonder if we can tell our compilers (or runtime checker) to help > catch a mistake like this. Did you see our sanitizers complain, or > something?
I accidentally came across this issue when I wanted to implement a new similar capability. I'm curious why adding "-Wuninitialized" or "-Wmaybe-uninitialized" to gcc fails to spot this case.