git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] object-info: init request_info before reading arg

From
Jiang Xin <worldhello.net@gmail.com>
Date
Apr 4, 2023, 01:07 UTC
Message-ID
<CANYiYbHB9AMpahiULEF=PoVG6y_ogDvVQvWY=ThKUdERmVbQyg@mail.gmail.com>
In-Reply-To
<xmqqsfdg7wif.fsf@gitster.g>
On Tue, Apr 4, 2023 at 12:36 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
>
> Jiang Xin <worldhello.net@gmail.com> writes:
>
> > From: Jiang Xin <zhiyou.jx@alibaba-inc.com>
> >
> > When retrieving object info via capability "object-info", we store the
> > command args into a requested_info variable, but forget to initialize
> > it. Initialize the variable before use to prevent unexpected output.
>
> Good eyes.  We read the request packets to decide if we want to flip
> the .size member of the structure, but the result would not make
> much sense if the structure starts with a random garbage in it.
>
> I wonder if we can tell our compilers (or runtime checker) to help
> catch a mistake like this.  Did you see our sanitizers complain, or
> something?

I accidentally came across this issue when I wanted to implement a new similar capability. I'm curious why adding "-Wuninitialized" or "-Wmaybe-uninitialized" to gcc fails to spot this case.

Previous: Junio C Hamano
Message 3 of 3 in “object-info: init request_info before reading arg”
  1. object-info: init request_info before reading argJiang Xin, Apr 2, 2023
  2. Junio C HamanoApr 3, 2023
  3. Jiang XinApr 4, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.