Re: [PATCH] builtin-commit.c: Not add duplicate S-o-b when commit

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jul 26, 2012, 07:15 UTC
Message-ID: <CANYiYbH0Jfk0LLp8HXVEamD0uRzM2OGJCE8W4h_UoDLh1pMVHA@mail.gmail.com>
In-Reply-To: <7vy5m781j5.fsf@alter.siamese.dyndns.org>

2012/7/26 Junio C Hamano <gitster@pobox.com>:

> After stating the observation like the above, please make it a habit
> to say "which is bad because...", if you think it is a bad behaviour
> and the patch is about fixing it.

Indead before I start, I examine git-commit and git-am, and find the behaviours of the two commands are different.

"git commit -s" checks the last line of the footer, while "git -am" checks the last S-o-b. E.g. original commit X:

    commit log...

    Signed-off-by: A
    Signed-off-by: B
    Reported-by: C

When user B amend the commit, the amended commit Y looks like:

    commit log...

    Signed-off-by: A
    Signed-off-by: B
    Reported-by: C
    Signed-off-by: B

While if the original commit X send to user B by patch, and user B run command "git am -s", the commit would be:

    Signed-off-by: A
    Signed-off-by: B
    Reported-by: C

So I guess duplicate S-o-b is not intentional.

I use an alias for commit:

    git config --global alias.ci "commit -s"

And will encounter duplicate S-o-b issues frequently, especially format-patch/send-email workflow.

-- 
Jiang Xin