git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v15 04/16] Refactor quote_path_relative, remove unused params

From
Jiang Xin <worldhello.net@gmail.com>
Date
Jun 27, 2013, 01:47 UTC
Message-ID
<CANYiYbGr4A-PQJtiLwBWd2xqkWBYUPvuVCnSOV4_=sL2qYssnQ@mail.gmail.com>
In-Reply-To
<7v61x0wypk.fsf@alter.siamese.dyndns.org>
2013/6/27 Junio C Hamano <gitster@pobox.com>:
Show 17 quoted lines
>> diff --git a/quote.c b/quote.c
>> index 64ff3..ebb8 100644
>
> You seem to be using unusually short abbrev length.
>
> Please don't, at least in format-patch output.
>
> "ebb8" may be unique within your repository, but may not be unique
> in repositories of other people who attempt to apply your patches.
>
> Offtopic.  Fixing this, without forcing you to use the default
> abbrev length everywhere, _might_ require a bit of changes to the
> configuration mechanism, or "git format-patch", or both.  I've also
> seen in some other thread that --numstat was used in addition to the
> usual --stat, which should not be added to format-patch output only
> because the user configured it for other "diff/log" uses, which may
> also need to be fixed in the same way.

Thank you for your notice. I find that I have a setting: core.abbrev=4, which overrides the default. Maybe I set it two years ago, when I wrote my book on Git in Chinese.

-- 
Jiang Xin
Previous: Junio C HamanoNext: Jiang Xin
Message 12 of 25 in “Interactive git clean”
  1. 00/16 Interactive git cleanJiang Xin, Jun 25, 2013
  2. 01/16 test: add test cases for relative_pathJiang Xin, Jun 25, 2013
  3. Junio C HamanoJun 26, 2013
  4. Jiang XinJun 27, 2013
  5. 02/16 path.c: refactor relative_path(), not only strip prefixJiang Xin, Jun 25, 2013
  6. Junio C HamanoJun 26, 2013
  7. Jiang XinJun 27, 2013
  8. 03/16 quote.c: substitute path_relative with relative_pathJiang Xin, Jun 25, 2013
  9. Junio C HamanoJun 26, 2013
  10. 04/16 Refactor quote_path_relative, remove unused paramsJiang Xin, Jun 25, 2013
  11. Junio C HamanoJun 26, 2013
  12. Jiang XinJun 27, 2013
  13. 05/16 Refactor write_name_quoted_relative, remove unused paramsJiang Xin, Jun 25, 2013
  14. 06/16 git-clean: refactor git-clean into two phasesJiang Xin, Jun 25, 2013
  15. 07/16 git-clean: add support for -i/--interactiveJiang Xin, Jun 25, 2013
  16. 08/16 git-clean: show items of del_list in columnsJiang Xin, Jun 25, 2013
  17. 09/16 git-clean: add colors to interactive git-cleanJiang Xin, Jun 25, 2013
  18. 10/16 git-clean: use a git-add-interactive compatible UIJiang Xin, Jun 25, 2013
  19. 11/16 git-clean: add filter by pattern interactive actionJiang Xin, Jun 25, 2013
  20. 12/16 git-clean: add select by numbers interactive actionJiang Xin, Jun 25, 2013
  21. 13/16 git-clean: add ask each interactive actionJiang Xin, Jun 25, 2013
  22. 14/16 git-clean: add documentation for interactive git-cleanJiang Xin, Jun 25, 2013
  23. 15/16 test: add t7301 for git-clean--interactiveJiang Xin, Jun 25, 2013
  24. 16/16 test: run testcases with POSIX absolute paths on WindowsJiang Xin, Jun 25, 2013
  25. Junio C HamanoJun 26, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.