Re: [PATCH v7 01/10] Add support for -i/--interactive to git-clean

From: Jiang Xin <worldhello.net@gmail.com>
Date: May 13, 2013, 14:46 UTC
Message-ID: <CANYiYbGX1w5YxxTJg4J0JrN1+3Kn-OK99ma+Qbi=VcRYR2o2TA@mail.gmail.com>
In-Reply-To: <vpqvc6oi1f6.fsf@grenoble-inp.fr>

2013/5/13 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:

Show 5 quoted lines

>> +             /* Confirmation dialog */
>> +             printf(_("Remove ([y]es/[n]o/[e]dit) ? "));
>
> To be more consistent with "git add -p", this should use [] instead of
> (), and have no space before "?".

Will be replaced with:

             printf(_("Remove [y/n]? "));

Show 7 quoted lines

>
>> +                     die(_("clean.requireForce defaults to true and neither -i, -n nor -f given; "
>>                                 "refusing to clean"));
>
> That makes it a 85 characters message, and we usually break lines before
> 80. Adding \n after ";" (instead of a space) would be better IMO.
>

If die with multiple lines, it looks ugly. E.g.

    % git clean
    fatal: clean.requireForce defaults to true and neither -i, -n nor -f given;
    refusing to clean

I think because of this, some die messages are longer than 80 characters. Such as:

    # builtin/apply.c:1496

    die(Q_("git diff header lacks filename information when removing "
                "%d leading pathname component (line %d)",
                "git diff header lacks filename information when removing "
                "%d leading pathname components (line %d)",

-- 
Jiang Xin
http://www.worldhello.net/