Re: [PATCH v6 13/16] commit-graph: new Bloom filter version that fixes murmur3
- From
Jiang Xin <worldhello.net@gmail.com>
- Date
- Feb 28, 2024, 00:11 UTC
- Message-ID
- <CANYiYbGEbvJHyDG1cQ9gKuRxdcCfwED6N2Ddn-PtVGSsmwOs4Q@mail.gmail.com>
- In-Reply-To
- <d2f11c082d3bf10d9127c330a7d59b7e47ac4f21.1706741516.git.me@ttaylorr.com>
On Thu, Feb 1, 2024 at 9:50 AM Taylor Blau <me@ttaylorr.com> wrote:
Show 8 quoted lines
> > diff --git a/Documentation/config/commitgraph.txt b/Documentation/config/commitgraph.txt > index e68cdededa..7f8c9d6638 100644 > --- a/Documentation/config/commitgraph.txt > +++ b/Documentation/config/commitgraph.txt > @@ -15,7 +15,7 @@ commitGraph.readChangedPaths:: > > commitGraph.changedPathsVersion::
The word commitGraph is in camelCase here.
Show 12 quoted lines
> diff --git a/commit-graph.c b/commit-graph.c
> index 6c3fbae142..6f9cab181e 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -2501,6 +2499,13 @@ int write_commit_graph(struct object_directory *odb,
> }
> if (!commit_graph_compatible(r))
> return 0;
> + if (r->settings.commit_graph_changed_paths_version < -1
> + || r->settings.commit_graph_changed_paths_version > 2) {
> + warning(_("attempting to write a commit-graph, but "
> + "'commitgraph.changedPathsVersion' (%d) is not supported"),To fix mismatched config variable, s/commitgraph/commitGraph/ See: https://github.com/git-l10n/pot-changes/blob/pot/seen/2024-02-27.diff#L32
-- Jiang Xin