Re: [PATCH v2 2/9] Makefile: generate "po/git.pot" from stable LOCALIZED_C

From: Jiang Xin <worldhello.net@gmail.com>
Date: May 19, 2022, 12:48 UTC
Message-ID: <CANYiYbGCwOCviu0x+2OJWR=AFWt1LwnZsN5DfB=C0ywdzz6HzQ@mail.gmail.com>
In-Reply-To: <220519.86pmk96fhv.gmgdl@evledraar.gmail.com>

On Thu, May 19, 2022 at 5:25 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 14 quoted lines

> > diff --git a/Makefile b/Makefile
> > index 83e968e2a4..60ca42c268 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2714,7 +2714,8 @@ XGETTEXT_FLAGS_SH = $(XGETTEXT_FLAGS) --language=Shell \
> >       --keyword=gettextln --keyword=eval_gettextln
> >  XGETTEXT_FLAGS_PERL = $(XGETTEXT_FLAGS) --language=Perl \
> >       --keyword=__ --keyword=N__ --keyword="__n:1,2"
> > -LOCALIZED_C = $(C_OBJ:o=c) $(LIB_H) $(GENERATED_H)
> > +LOCALIZED_C = $(FOUND_C_SOURCES) $(SCALAR_SOURCES) \
> > +           $(FOUND_H_SOURCES) $(GENERATED_H)
>
> The SCALAR_SOURCES seems snuck in here, but it's worth noting in the
> commit message that we effectively had it here before as part of C_OBJ.

Agree.