Re: [L10N] fixed mismatched variable names

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jul 3, 2021, 14:33 UTC
Message-ID: <CANYiYbG3SVqwnHv67K8JGNxHBBC+EY-LGWCsmt4ZQJOY2Me8yg@mail.gmail.com>
In-Reply-To: <87sg0v8vr8.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> 于2021年7月3日周六 下午7:47写道：

Show 13 quoted lines

>
> This seems like a good narrow fix for now, but I'd think a much better
> fix would be to e.g. add something to the CI or a lintk check based on
> "git help --config" that errored if any string meant for gettext
> contains such a variable.
>
> It's data that isn't meant to be translated at all, so we should be
> passing it as %s to the format string.
>
> I see there's at least one fix that fixes a reference to a function
> internal to git.git, such a check wouldn't catch that, but that message
> should be fixed too. We shouldn't have anything referencing code names
> except the BUG() messages (which we don't translate)>

There are at least three types of constant strings that should not be translated: git config variables, function or variable names, git commands or command options. See new test cases in commit:

https://github.com/git-l10n/git-po-helper/commit/86791cf25b17b6853bcbad7b501a76906ac86a02