Re: [PATCH v2 5/5] docs(l10n): add AI agent instructions to review translations
- From
Jiang Xin <worldhello.net@gmail.com>
- Date
- Mar 12, 2026, 02:34 UTC
- Message-ID
- <CANYiYbG3CtSnis4NfhsH3SLyTPEurW2acqtj3snt4FO-2X809A@mail.gmail.com>
- In-Reply-To
- <d7a7a07acdcf15520019fc58be5e6a1a1e24791a.1772551123.git.worldhello.net@gmail.com>
On Tue, Mar 3, 2026 at 11:34 PM Jiang Xin <worldhello.net@gmail.com> wrote:
Show 27 quoted lines
> +### Task 4: Review translation quality > + > +Review may target the full `po/XX.po`, a specific commit, or changes since a > +commit. When asked to review, follow the steps below. **Note**: This task uses > +`git-po-helper compare`; if `git-po-helper` is not available, the task > +cannot be performed. > + > +1. **Check for existing review**: Evaluate the following in order: > + > + - If `po/review-input.po` does **not** exist, proceed to step 2 regardless > + of any other files (e.g., batch or JSON files). > + - If both `po/review-input.po` and `po/review-result.json` exist, go > + directly to step 5 (Merge and summary) and display the report. > + Do **not** check for batch or other temporary files; no further review > + steps are needed. > + - If `po/review-input.po` exists but `po/review-result.json` does not, > + go to step 4 (Process one batch) to continue the previous review. > + > +2. **Extract entries**: Run `git-po-helper compare` with the desired range and > + redirect the output to `po/review-input.po`. Do not use `git show` or > + `git diff`—they can fragment or lose PO context (see "Comparing PO files > + for translation and review" under git-po-helper). > + > +3. **Prepare review batches**: Run the script below to clean up any leftover > + files from previous reviews and split `po/review-input.po` into one or > + more `po/review-input-<N>.json` files (dynamic batch sizing). Run as a > + single script (define the function, then call it):
In the v3 reroll, we will adopt a solution that is easier for the model to understand: using a single pending file to record data awaiting review, rather than splitting review tasks across multiple files and requiring the model to select among them.
> + git-po-helper msg-select --json --range "-$NUM" \ > + -o "po/review-input-$i.json" po/review-input.po
There are trailing spaces in this file that are breaking CI. This will be fixed in the v3 reroll.