Re: Need help in understanding how to submit a patch

From: Jiang Xin <worldhello.net@gmail.com>
Date: Nov 18, 2021, 01:13 UTC
Message-ID: <CANYiYbG0CF0hC+yamdNFz8cytB+W4onRkqXusNoWR1xv2aqJzw@mail.gmail.com>
In-Reply-To: <20211117175149.7slohfqqwsmn3ua6@yadavpratyush.com>

On Thu, Nov 18, 2021 at 3:34 AM Pratyush Yadav <me@yadavpratyush.com> wrote:

Show 29 quoted lines

>
> Hi Etienne,
>
> On 17/11/21 03:47PM, Philip Oakley wrote:
> > On 16/11/2021 21:15, Etienne Guillot wrote:
> > > Hi,
> > >
> > > I found a typo mistake in the french translation of git-gui.
> > > I did read the instructions on this page
> > > https://git-scm.com/docs/SubmittingPatches
> > > but I still not sure where should I push the correction.
> > >
> > > Thanks for your help
> > >
> > > Etienne Guillot
> > Hi Etienne
> >
> > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at
> > https://github.com/prati0100/git-gui
> >
> > Not sure what the latest is on contributing translations (not covered in
> > the GitHub Readme..).
>
> I usually ask people to post patches on this mailing list and I review
> them here. But I make an exception for translation changes since they
> never get any reviews anyway.
>
> So I am fine with either a Pull Request on GitHub or a patch on the
> mailing list.

For l10n of git project (not git-gui), different l10n teams use different code review strategy, but at last all l10n team leaders will send pull requests to "git-l10n/git-po" on GitHub. There are some sort of code reviews for l10n and most of them are basically focused on commit logs and typos. See:

    https://github.com/git-l10n/git-po/pulls?q=is%3Apr+is%3Aclosed

Starting from the recent release cycle of git 2.34.0, l10n of git has a CI workflow and the CI robot can give some review suggestions for l10n contributions using a helper program.

    https://github.com/git-l10n/git-po/actions/workflows/l10n.yml?query=event%3Apull_request_target

The helper program can be rewrite to help l10n for git-gui project.

    https://github.com/git-l10n/git-po-helper

-- Jiang Xin