Re: [PATCH] i18n: po for zh_cn

From: Jiang Xin <worldhello.net@gmail.com>
Date: Feb 2, 2012, 03:56 UTC
Message-ID: <CANYiYbF+ZqGVdpxXzBkPMUwoWO+EdSb1WHqUCdQEmj5AjR1LDw@mail.gmail.com>
In-Reply-To: <CACBZZX6mHQ8NLWiBjp5OtDpFAc1=s9XfzHY5HhQ-26pqLXQ3bg@mail.gmail.com>

2012/2/2 Ævar Arnfjörð Bjarmason <avarab@gmail.com>:

Show 5 quoted lines

> On Wed, Feb 1, 2012 at 16:50, Jiang Xin <worldhello.net@gmail.com> wrote:
>> Git can speak Chinese now.
>
> That's very nice, and it passes the msgfmt --check test as well, so
> all looks good.

One bug, the filename should be zh_CN.po, not zh_cn.po. On my Mac, the filesystem is case insensitive, locale works fine, but in Linux won't.

I will send the patch again with correct filename and with translates for news message from Git master branch. (previous l10n is against git v1.7.9, i.e. the maint branch)

Show 5 quoted lines

>
> As an aside doesn't the bug / workaround described in
> https://github.com/git/git/blob/master/gettext.c#L35 impact chinese
> especially badly? I'd expect any place where we use strerror() to show
> up as total gibberish.

The perror test program does impact chinese too. On Linux with well translated system error messages, with the following output:

    $ ./test
    test: ??????

On Mac without translated system error messages, output is all ascii.

-- 
Jiang Xin