Re: [PATCH v7 0/3] some enhancements for reporting branch tracking info

From: Jiang Xin <worldhello.net@gmail.com>
Date: Aug 19, 2013, 00:38 UTC
Message-ID: <CANYiYbEtWF3m_ACActD2TDjhXh_=1qJ07Rgc3mb8Nfgogjh-RQ@mail.gmail.com>
In-Reply-To: <7v7gfiojz7.fsf@alter.siamese.dyndns.org>

2013/8/19 Junio C Hamano <gitster@pobox.com>:

Show 6 quoted lines

>
> I however feel that [1/3] is introducing a regression (what we used
> to report, gone branches, are hidden), only to correct the
> regression immediately after it with [2/3].
>
> I wonder if these patches should be combined into one

Yes, at least patch 1/3 and patch 2/3 can be squashed into one.

> justification like "with the current code, a branch that is in sync
> with its upstream, a branch whose upstream no longer exists and a
> branch that does not build on anything else cannot be distinguished;
> show the first class as 'same', mark the second class as 'gone', and

For the first class, if there are differences between branch and its upstream, tracking info is displayed, but report nothing if they are identical. I do think report something in this case is useful. It may help me to find out which remote I am tracking, if there are several remotes for my repo.

> show only the last one as 'not having any uptream', or something.

I think keep silence in this case is better.

-- 
Jiang Xin