Re: cc/list-objects-filter-wo-sparse-path, was Re: What's cooking in git.git (May 2019, #05; Thu, 30)

From: Jiang Xin <worldhello.net@gmail.com>
Date: Jun 2, 2019, 14:32 UTC
Message-ID: <CANYiYbEYcZu3hOXdvFXo-hZo-=vZobYX-M-0dGMmp4TKM3p3nA@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1905312224020.1775@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> 于2019年6月1日周六 上午4:26写道：

Show 30 quoted lines

>
> Hi Junio,
>
> On Fri, 31 May 2019, Junio C Hamano wrote:
>
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> > >> * cc/list-objects-filter-wo-sparse-path (2019-05-29) 1 commit
> > >>   (merged to 'next' on 2019-05-30 at 5a294203ad)
> > >>  + list-objects-filter: disable 'sparse:path' filters
> > >>
> > >>  Disable "--filter=sparse:path=<path>" that would allow reading from
> > >>  paths on the filesystem.
> > >>
> > >>  Will cook in 'next'.
> > >
> > > Not sure whether we want to fast-track this into v2.22.0. There is a risk.
> > >
> > > But then, the longer we ship with `--filter=sparse:path` *enabled*, the
> > > more we invite users to actually try and use it.
> >
> > This one I wasn't quite decided on, for exactly the same reason why
> > you said "Not sure".  I am inclined to merge it to 'master' at this
> > point, as it indeed is a risk to keep it enabled.
> >
> > The only remaining question it raises is if it makes it worthwhile
> > to add another rc; it introduces one new localizable string, too.
>
> That'd be more a question to the L10N coordinator (who you Cc:ed)... Jiang
> Lin? Would that require another -rc?

Current l10n round 2 is based on v2.22.0-rc2, and only 5 days left for the final release. If merge the topic "cc/list-objects-filter-wo-sparse-path" to master, a -rc3 is needed for the new message introduced:

    +#: list-objects-filter-options.c:84
    +msgid "sparse:path filters support has been dropped"
    +msgstr ""

-- Jiang Xin