Re: [PATCH 2/2] builtin/repo: fix table alignment for UTF-8 characters

From: Jiang Xin <worldhello.net@gmail.com>
Date: Nov 15, 2025, 12:54 UTC
Message-ID: <CANYiYbEFN9BHtNh1PQ9C3gDJasq1PaKnkcH-Nq=FddUCAcMGqg@mail.gmail.com>
In-Reply-To: <xmqqa50oiduy.fsf@gitster.g>

On Sat, Nov 15, 2025 at 4:00 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

>
> Jiang Xin <worldhello.net@gmail.com> writes:
>
> Not about the contents of the patch, but how was the list of
> addresses on CC produced?  Do they all have enough stakes in the
> code being updated that they do not mind getting spammed like this?

I’m cc’ing this patch series to all Git l10n team leads to inform them that the issue has been identified and will be fixed.

> Also, you had a non-address "Gemini <noreply@developers.google.com>",
> which forced me and anybody who will respond to the patch edit Cc
> address list (or suffer bounces).  Please don't.

Will remove this trailer.

Show 6 quoted lines

> >     |     * 提交   |  279 |
> >     |     * 树      |  740 |
> >     |     * 数据对象 | 1168 |
> >     |     * 标签   |   30 |
>
> As there is a concrete reproduction sample from a specific tool, ...

This output of the `git repo structure` command is based on the Chinese translation for Git 2.52. The next reroll will retain only the table header, which is sufficient to demonstrate the issue.

Show 6 quoted lines

>
> >  builtin/repo.c | 22 ++++++++++++++++++----
> >  1 file changed, 18 insertions(+), 4 deletions(-)
>
> ... it is a good idea to protect the change with a new test or two
> to make sure the expected alignment in the output.

Will add test cases for strbuf_utf8_align(), a function newly introduced in builtin/repo.c.