git/list[1] front-page[2] threads[3] people[4] search[5] about
 

New NULL dereference in sequence.c

From
MMMichael Mueller <mmueller@vigilantsw.com>
Date
May 2, 2012, 08:45 UTC
Message-ID
<CANV9Rr9PFR7SA_3jB-6PRF_V+4yB-FsYEuX5gs-LMpoTAxGDCQ@mail.gmail.com>
Hi all,

The last defect Sentry picked up has been removed, yay! At the same time, a new NULL dereference bug appeared, in sequencer.c:

    static int is_index_unchanged(void)
    {
        unsigned char head_sha1[20];
        struct commit *head_commit;
        if (!resolve_ref_unsafe("HEAD", head_sha1, 1, NULL))
            return error(_("Could not resolve HEAD commit\n"));
        head_commit = lookup_commit(head_sha1);
        if (!head_commit || parse_commit(head_commit))
            return error(_("could not parse commit %s\n"),
                     sha1_to_hex(head_commit->object.sha1));

In the last line quoted above, head_commit may be NULL, and it is dereferenced in the call to sha1_to_hex. Assuming lookup_commit(head_sha1) can return NULL, this function will segfault.

Introduced here: https://github.com/gitster/git/commit/b27cfb0#sequencer.c

Mike
-- 
Mike Mueller
Phone: (401) 405-1525
Email: mmueller@vigilantsw.com

http://www.vigilantsw.com/
Next: René Scharfe
Message 1 of 5 in “New NULL dereference in sequence.c”
  1. Michael MuellerMay 2, 2012
  2. René ScharfeMay 2, 2012
  3. Neil HormanMay 2, 2012
  4. Matthieu MoyMay 2, 2012
  5. Neil HormanMay 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.