git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

From
Jakub Narębski <jnareb@gmail.com>
Date
Dec 2, 2013, 18:25 UTC
Message-ID
<CANQwDwe827gsq4pP_XN_ZUSxTJhZupijuVK0gwVJToNcEXDueg@mail.gmail.com>
In-Reply-To
<xmqq61r7rua0.fsf@gitster.dls.corp.google.com>
On Mon, Dec 2, 2013 at 7:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> Krzesimir Nowak <krzesimir@endocode.com> writes:
>> On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote:
>>> On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak
>>> <krzesimir@endocode.com> wrote:
>>>
>>> > Allow @additional_branch_refs configuration variable to tell gitweb to
>>> > show refs from additional hierarchies in addition to branches in the
>>> > list-of-branches view.
>>> >
>>> > Signed-off-by: Krzesimir Nowak <krzesimir@endocode.com>
>>>
>>> Why not use %feature hash instead of adding new configuration variable?
>>> I think that this option is similar enough to 'remote_heads' feature
>>> (which BTW should be 'remote-heads'), and could conceveilably enabled
>>> on a per-repository basis, i.e. with repository configuration override,
>>> isn't it?
>>
>> I'd like to see some consensus on it before I start changing the patch
>> again.
>
> I missed the remote-heads which is an existing feature when I
> commented; if this can be exposed to the users as an extension to
> it like Jakub suggests, it may be a better direction.

I think that additional-branch-refs (or just branch-refs) is different enough from remote_heads feature (which is about showing "remotes" section in "summary" view, and IIRC adding "remotes" view) that it should be kept separate.

On the other hand it is similar enough that I think style of implementation should also be similar, i.e. use %feature hash.

IMVHO
-- 
Jakub Narebski
Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 12 in “gitweb: Add an option for adding more branch refs”
  1. gitweb: Add an option for adding more branch refsKrzesimir Nowak, Nov 28, 2013
  2. Eric SunshineNov 29, 2013
  3. Krzesimir NowakDec 2, 2013
  4. Jakub NarębskiDec 2, 2013
  5. Krzesimir NowakDec 2, 2013
  6. Jakub NarębskiDec 2, 2013
  7. Krzesimir NowakDec 3, 2013
  8. Jakub NarębskiDec 3, 2013
  9. Krzesimir NowakDec 3, 2013
  10. Junio C HamanoDec 2, 2013
  11. Jakub NarębskiDec 2, 2013
  12. Junio C HamanoDec 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.