git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[bug] forcing build settings on rhel7 without specific checks is not appropriate

From
AKAlexander Kanavin <alex.kanavin@gmail.com>
Date
Feb 7, 2022, 11:13 UTC
Message-ID
<CANNYZj8L_-hhKGNvNfiSU4T2W0g8ZRJ-gJJ30PgRo=ycCGSObQ@mail.gmail.com>
Hello,

there was a recent change where a couple of compiler settings are forced on rhel7:

# centos7/rhel7 provides gcc 4.8.5 and zlib 1.2.7.
ifneq ($(findstring .el7.,$(uname_R)),)
    BASIC_CFLAGS += -std=c99
    NO_UNCOMPRESS2 = YesPlease
endif

I believe this is not the right way to do it: the makefile should check for the actual compiler and zstd versions and make the decision based on that. Yocto project uses a much newer (cross)compiler and zlib for cross-builds, and those settings are not only unnecessary, but actively harm reproducibility, as cross-binaries built on rhel7/centos7 are then not the same as binaries built on other distributions. So we ended up reverting the change: https://lists.openembedded.org/g/openembedded-core/message/161456

Thanks, Alex

Message 1 of 1 in “[bug] forcing build settings on rhel7 without specific checks is not appropriate”
  1. Alexander KanavinFeb 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.