Re: [PATCH 0/3] git-prompt: add quiet upstream indicator option

From: Kiril Ivanov <ivanovkirilg@gmail.com>
Date: Nov 16, 2025, 12:05 UTC
Message-ID: <CANHi5upZdwi33upTFL01NymMqK7dCWEbj8XAOEydCDMf4bSFzw@mail.gmail.com>
In-Reply-To: <xmqqjyzrdpqu.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> wrote:

> ... (this is a reaction to seeing
> some bash-isms in these patches.  No complaints here, as the test
> script is all about the command line prompt feature to be used with
> bash and nothing else).

Actually, this got me reconsidering. The prompt feature claims at least to support zsh in addition to bash, and it has had modifications to make it more compliant:

<pull.1750.git.git.1721762306.gitgitgadget@gmail.com>

> After this patchset, the following shells work: bash, zsh, dash (since at
> least 0.5.8), free/net bsd sh, busybox-ash, mksh, openbsd sh, pdksh(!),
> Schily extended Bourne sh (bosh), yash.

And the test seems to run successfully under 'sh' in master with: -. ./lib-bash.sh +. ./test-lib.sh (Passes normally, and fails when the 'expected' strings are clobbered.)

... Which is all to say that the bash-isms may be undesirable even here.

Unfortunately, I have been struggling (for an embarrassing couple of hours) to replace them with something standard that still keeps the matrix-like form of the test parameters. If anyone more experienced in scripting has an itch to help, it's welcome.

Since I originally intended this to be a two-line change, I'd rather wait to see if it is even a welcome addition before I spend more time on it.

Thanks Junio for the feedback!