git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] help.c: strip suffix only if the STRIP_EXTENSION defined

From
Alexander Kuleshov <kuleshovmail@gmail.com>
Date
Mar 16, 2016, 17:36 UTC
Message-ID
<CANCZXo6KGtuuiZ3aha=Tqkwj3d8qytmA_rvw7fPHfevzz9Qyfg@mail.gmail.com>
In-Reply-To
<20160316173127.GD4039@sigill.intra.peff.net>
Hello Jeff,
On Wed, Mar 16, 2016 at 11:31 PM, Jeff King <peff@peff.net> wrote:
Show 11 quoted lines
> This is billed as an optimization in the commit message, but these two
> pieces of code are not the same. The original always strips ".exe",
> whether or not STRIP_EXTENSION is defined, and whether or not it is
> ".exe".
>
> In practice it works out because people on Unix systems do not have
> "git-foo.exe", and nobody sets STRIP_EXTENSION to other things.  But I
> tend to think this is an improvement in robustness.
>
> I also wonder if this should be sharing the strip_extension() helper
> added in your 63ca1c0.

Yes, I want to move strip_extension() (from 63ca1c0) to the git-compat-util.h and adapt/reuse it in the help.c. What do you think about this?

Thank you.
Previous: Jeff KingNext: Jeff King
Message 5 of 6 in “help.c: strip suffix only if the STRIP_EXTENSION defined”
  1. help.c: strip suffix only if the STRIP_EXTENSION definedAlexander Kuleshov, Mar 16, 2016
  2. Duy NguyenMar 16, 2016
  3. Alexander KuleshovMar 16, 2016
  4. Jeff KingMar 16, 2016
  5. Alexander KuleshovMar 16, 2016
  6. Jeff KingMar 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.