git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fsmonitor inline / testing cleanup

From
Nipunn Koorapati <nipunn1313@gmail.com>
Date
Oct 21, 2020, 23:15 UTC
Message-ID
<CAN8Z4-WxLcBzxrRsj4sRmMAKRZyLXpMA82r0Ce7RUiegtHWQ3Q@mail.gmail.com>
In-Reply-To
<20201021205208.GA1270359@nand.local>
> I'm fine with both of these patches, but it may help to have a bit
> more information about how they will be used. Presumably more patches
> are coming that make use of the new public functions, but it'd be good
> to know a little bit of why these changes are necessary.

I believe the externs are just there to avoid pulling in `dir.h` from the include file - since it's only needed in the implementation. I believe at the time (12/2017) `dir.h` was not imported from `fsmonitor.h`, but it does appear imported now. I've eliminated the import of `dir.h` as it no longer appears necessary - which I will include in the next iteration of this diff.

The test helper merely makes it easier to debug fsmonitor tests - will be useful to any developer working on fsmonitor related changes. I have an upcoming one related to fsmonitor in git checkout, which I've also revived, but I'm not 100% sure I'll get it through, but regardless, I believe this test-debugging change will be good.

--Nipunn
Previous: Taylor BlauNext: Nipunn Koorapati via GitGitGadget
Message 10 of 18 in “fsmonitor inline / testing cleanup”
  1. 0/2 fsmonitor inline / testing cleanupNipunn Koorapati via GitGitGadget, Oct 21, 2020
  2. 2/2 fsmonitor: make output of test-dump-fsmonitor more conciseAlex Vandiver via GitGitGadget, Oct 21, 2020
  3. 1/2 fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalidAlex Vandiver via GitGitGadget, Oct 21, 2020
  4. Taylor BlauOct 21, 2020
  5. Junio C HamanoOct 21, 2020
  6. Taylor BlauOct 21, 2020
  7. Junio C HamanoOct 21, 2020
  8. Nipunn KoorapatiOct 21, 2020
  9. Taylor BlauOct 21, 2020
  10. Nipunn KoorapatiOct 21, 2020
  11. 0/2 fsmonitor inline / testing cleanupNipunn Koorapati via GitGitGadget, Oct 22, 2020
  12. 2/2 fsmonitor: make output of test-dump-fsmonitor more conciseAlex Vandiver via GitGitGadget, Oct 22, 2020
  13. 1/2 fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalidAlex Vandiver via GitGitGadget, Oct 22, 2020
  14. Taylor BlauOct 22, 2020
  15. Junio C HamanoOct 22, 2020
  16. Taylor BlauOct 22, 2020
  17. Junio C HamanoOct 22, 2020
  18. Nipunn KoorapatiOct 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.