git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] dir.c: fix comments to agree with argument name

From
Nipunn Koorapati <nipunn1313@gmail.com>
Date
Oct 16, 2020, 12:39 UTC
Message-ID
<CAN8Z4-Wiun-e1s5v2G_2qucy_BmWm=fomd=t3=ZU=9KBu_cVCA@mail.gmail.com>
In-Reply-To
<xmqqsgafdyri.fsf@gitster.c.googlers.com>

Sounds good to me. Please let me know if there's anything further I need to do. I'm relatively new to git contributions - and my understanding is that at this point a maintainer would merge the commit at their leisure. Happy to do any further cleanup required to make that possible

Thanks --Nipunn

On Thu, Oct 15, 2020 at 9:23 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
>
> Jeff King <peff@peff.net> writes:
>
> >> Anyway.  Nipunn, can you fix both of them in the same commit, as
> >> they are addressing a problem from the same cause (i.e. we are no
> >> longer SHA-1 centric).
> >
> > The v2 that Nipunn sent with "oid" in the comment looks good to me.
>
> OK, then all is good.  Thanks.
Previous: Junio C HamanoNext: Nipunn Koorapati via GitGitGadget
Message 7 of 8 in “dir.c: fix comments to agree with argument name”
  1. dir.c: fix comments to agree with argument nameNipunn Koorapati via GitGitGadget, Oct 15, 2020
  2. Jeff KingOct 15, 2020
  3. Junio C HamanoOct 15, 2020
  4. Nipunn KoorapatiOct 15, 2020
  5. Jeff KingOct 15, 2020
  6. Junio C HamanoOct 15, 2020
  7. Nipunn KoorapatiOct 16, 2020
  8. dir.c: fix comments to agree with argument nameNipunn Koorapati via GitGitGadget, Oct 15, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.