[Outreachy] Return value before or after free()?
- From
Miriam R. <mirucam@gmail.com>
- Date
- Jan 6, 2020, 21:15 UTC
- Message-ID
- <CAN7CjDDBA0ZoCG9aaQf5rg3gxqny=EjR6v6jE1mnxvUJQSF_0Q@mail.gmail.com>
Dear all, in run-command.c file `exists_in_PATH()` function does this:
static int exists_in_PATH(const char *file) { char *r = locate_in_PATH(file); free(r); return r != NULL; }
I wonder if it is correct to do return r != NULL; after free(r);
Could be this version more readable? :
static int exists_in_PATH(const char *file) { char *r = locate_in_PATH(file); int res = (r != NULL); free(r); return res; }
Could you please give me your feedback?
Thank you!
Best, Miriam.