Re: "Your branch is up-to-date ..." is incorrect English grammar

From: Martin Ågren <martin.agren@gmail.com>
Date: Aug 21, 2017, 09:37 UTC
Message-ID: <CAN0heSrh_+J=LQnGZtngxQbcHAjFhX9vPKKDa7_ORz4iDpXf=g@mail.gmail.com>
In-Reply-To: <CAJXxHvVzTrhJk6pFsOzUKBuU2VcW41-tMk5A7s+rxXsacXpppw@mail.gmail.com>

The code base contains a few instances of "up-to-date" and "up to date". A tree wide sweep could be made to update user-visible strings in the code and in the documentation. Fixing source code comments seems like overkill. Could I count on you to review any changes I'd propose? (With respect to the English, that is.)On 21 August 2017 at 10:21, STEVEN WHITE <stevencharleswhitevoices@gmail.com> wrote:

Show 13 quoted lines

> Either of these two options is CORRECT:
>
> “Your branch is up to date …”
>
> “You have an up-to-date branch …”
>
> But “your branch is up-to-date” is INCORRECT. And, because it’s
> incorrect, it conveys an odd and unsettling experience to native
> English speakers whenever they read it.
>
> If you’re curious, you can find plenty of discussion of this point of
> grammar. Here’s just one example:
> https://english.stackexchange.com/questions/180611/do-i-keep-myself-up-to-date-or-up-to-date-on-something.

There is also some previous discussion on this very list: https://public-inbox.org/git/CALFtnmeRxgetuCVbO8ZmVkCR302vQ2s4hTPoHxAe5NEfmjtXEg@mail.gmail.com/T/#u

The code base contains a few instances of "up-to-date" and "up to date". A tree wide sweep could be made to update user-visible strings in the code and in the documentation. Fixing source code comments seems like overkill. Could I count on you to review any patches I'd propose? (With respect to the English, that is.)

Obviously, if you'd like to attempt a patch, that's fine by me. :)

Martin