Re: [PATCH v1 0/2] minor asciidoc/tor formatting fixes
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Apr 5, 2019, 10:23 UTC
- Message-ID
- <CAN0heSrbjRExHwch0K_W+xwpERnFUJmaiHhCkAaK9nnxFnXEhw@mail.gmail.com>
- In-Reply-To
- <20190405014040.GR4047@pobox.com>
Hi Todd,
On Fri, 5 Apr 2019 at 03:40, Todd Zullinger <tmz@pobox.com> wrote:
Show 8 quoted lines
> > On Sat, 30 Mar 2019 at 19:30, Todd Zullinger <tmz@pobox.com> wrote: > >> > >> Just chipping away at the remaining differences between asciidoc and > >> asciidoctor. > >> > >> Todd Zullinger (2): > >> Documentation/rev-list-options: wrap --date=<format> block with "--" > >> Documentation/git-status: fix titles in porcelain v2 section
Show 7 quoted lines
> There are two other changes I've got queued locally. One in
> git-show-branch.txt removes the last use of {apostrophe}.
> Another in git-svn.txt is a bit of a work-around for a
> difference in the way asciidoc and asciidoctor parse the
> second paragraph in the CONFIGURATION section. That may
> well be an asiidoctor bug, but it seems like one we can
> adjust for without much effort.The second one looks like it can be fixed by using `*` instead of '\*', which I think is more correct anyway. I don't know what your local workaround looks like, but I think a patch like "use backticks consistently" (both change to them, in a number of places, and add them, where we currently have nothing) would be a good change by itself, and we could note that "BTW, this fixes ...". How does that compare to what you have?
Martin