Re: [PATCH v2 0/6] reroll ma/plugleaks; more `object_array`-fixes

From: Martin Ågren <martin.agren@gmail.com>
Date: Sep 23, 2017, 09:54 UTC
Message-ID: <CAN0heSrPBDi4q9fqr=qoTbjRHpFS_VEL0O8=MFFJ4DLCuJwahA@mail.gmail.com>
In-Reply-To: <20170923043701.4s3xuytp5hdjwmsy@sigill.intra.peff.net>

On 23 September 2017 at 06:37, Jeff King <peff@peff.net> wrote:

Show 13 quoted lines

> On Sat, Sep 23, 2017 at 01:34:48AM +0200, Martin Ågren wrote:
>
>> Martin Ågren (6):
>>   builtin/commit: fix memory leak in `prepare_index()`
>>   commit: fix memory leak in `reduce_heads()`
>>   leak_pending: use `object_array_clear()`, not `free()`
>>   object_array: use `object_array_clear()`, not `free()`
>>   object_array: add and use `object_array_pop()`
>>   pack-bitmap[-write]: use `object_array_clear()`, don't leak
>
> All six look good to me. Thanks again for poking into this. I'm afraid
> to ask how far we have left to go on running the test suite all the way
> through with leak-checking turned on. :)

Thanks for reviewing.

Unfortunately, I have not figured out how to get LSan to simply report the leaks and continue. Its default behavior is to abort if there are leaks. That's useful for finding the first leaking test, but not much else. (Later tests might depend on that test doing everything it should, so now those later tests will start failing and/or executing different code paths.)

I can tell LeakSanitizer to exit with an exit code instead, but then all leaking git-processes exit with the same exit code. That also interferes with the tests.

What I would like is for the git-process to exit with the same exit status it would have had without the leak-checking. That would make it possible to run the whole test suite, collect all leaks, identify duplicates, sort them, categorize them, prioritize them, track how we are progressing...

I did spend some time looking into this before I gave up. I'd love to be told I've missed something obvious.

Martin