Re: [PATCH] gc: fix regression in 7b0f229222 impacting --quiet

From: Martin Ågren <martin.agren@gmail.com>
Date: Sep 19, 2018, 21:21 UTC
Message-ID: <CAN0heSr=upqAVzjm=gQoGVnOjBZcDWhmj3W8gFFa8bcfCgaHTg@mail.gmail.com>
In-Reply-To: <20180919210138.31940-1-avarab@gmail.com>

On Wed, 19 Sep 2018 at 23:04, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> Fix a regression in my recent 7b0f229222 ("commit-graph write: add
> progress output", 2018-09-17), the newly added progress output for
> "commit-graph write" didn't check the --quiet option.

s/, t/. T/, perhaps. Maybe also s/did/does/.

> Do so, and add a test asserting that this works as expected. Since the
> TTY perquisite isn't available everywhere let's add a version of this

s/perq/prereq/

> that both requires and doesn't require that. This test might be overly
> specific and will break if new progress output is added, but I think
> it'll serve as a good reminder to test the undertested progress
> mode(s).

> +test_expect_success 'gc --no-quiet' '
> +       git -c gc.writeCommitGraph=true gc --no-quiet >stdout 2>stderr &&
> +       ! test -s stdout &&

`test_must_be_empty` for easier debugging?

> +       test_line_count = 1 stderr &&
> +       test_i18ngrep "Computing commit graph generation numbers" stderr
> +'