Re: [PATCH 2/2] pretty-formats.txt: add missing space

From: Martin Ågren <martin.agren@gmail.com>
Date: May 9, 2021, 15:27 UTC
Message-ID: <CAN0heSqi9v3dGgGFSGB7J-17MJj9jOvMwC6x7pW1bRGwra5N2g@mail.gmail.com>
In-Reply-To: <CAOLTT8R2ACJtcL7esLd8AiSu22Wn2hrdVTwub-HXc-eT_U2-+w@mail.gmail.com>

On Sun, 9 May 2021 at 16:13, ZheNing Hu <adlternative@gmail.com> wrote:

Show 7 quoted lines

>
> Martin Ågren <martin.agren@gmail.com> 于2021年5月9日周日 下午5:10写道：
> >
> > The description of "%ch" is missing a space after "human style", before
> > the parenthetical remark. This description was introduced in b722d4560e
> > ("pretty: provide human date format", 2021-04-25). That commit also
> > added "%ah", which does have the space already.

Show 9 quoted lines

> > --- a/Documentation/pretty-formats.txt
> > +++ b/Documentation/pretty-formats.txt
> > @@ -208,7 +208,7 @@ The placeholders are:
> >  '%ci':: committer date, ISO 8601-like format
> >  '%cI':: committer date, strict ISO 8601 format
> >  '%cs':: committer date, short format (`YYYY-MM-DD`)
> > -'%ch':: committer date, human style(like the `--date=human` option of
> > +'%ch':: committer date, human style (like the `--date=human` option of
> >         linkgit:git-rev-list[1])

Show 5 quoted lines

> Sorry, but in here:[1], I have fixed this space missing error.
>
> Junio, this patch have not been merged to master?
>
> [1]: https://lore.kernel.org/git/pull.939.v4.git.1620056221874.gitgitgadget@gmail.com/

Ah, thanks for the pointer. It looks like this was merged to "next" in 2320ad8fb0 ("Merge branch 'zh/pretty-date-human' into next", 2021-04-30), so a few days before you sent v4.

Junio probably missed v4 entirely, or he might have responded with something like "v3 is already in next, so please build incrementally on top of it".

Thanks for contributing this functionality. I quite like the "human" format.

Martin