Re: What's cooking in git.git (Feb 2020, #05; Tue, 25)

From: Martin Ågren <martin.agren@gmail.com>
Date: Feb 26, 2020, 20:54 UTC
Message-ID: <CAN0heSqfEsEZVBnFP0cSNoB-gK=EG1nuDL0EQHHc8MSH=TcPRw@mail.gmail.com>
In-Reply-To: <xmqqo8tml1lv.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 25 Feb 2020 at 23:58, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> * es/recursive-single-branch-clone (2020-02-25) 2 commits
>  - clone: pass --single-branch during --recurse-submodules
>  - submodule--helper: use C99 named initializer
>
>  "git clone --recurse-submodules --single-branch" now uses the same
>  simgle-branch option when cloning the submodules.

s/simgle/single/

Show 8 quoted lines

> * jc/describe-misnamed-annotated-tag (2020-02-20) 1 commit
>  - describe: force long format for a name based on a mislocated tag
>
>  When "git describe C" finds an annotated tag with tagname A to be
>  the best name to explain commit C, and the tag is stored in a
>  "wrong" place in the refs/tags hierarchy, e.g. refs/tags/B, the
>  command gave a warning message but used A (not B) to describe C.
>  If C is exactly at the tag, the desribe output would be "A", but

s/desribe/describe/

>  "git rev-parse A^0" would not be equal as "git rev-parse C^0".  The
>  behaviour of the command has been changed to use the "long" form

("behavior" in American English.)

> * jk/object-filter-with-bitmap (2020-02-18) 16 commits
>   (merged to 'next' on 2020-02-19 at d38487e23d)

>  The object reachability bitmap machinery and the partial cloning
>  machinery were not prepared to work well together, because some
>  object-filtering criteria partial clones use inherently rely on

Perhaps inject "which" between "criteria" and "partial".

>  object traversal, but the bitmap machinery is an optimization to
>  bypass that object traversal.  There however are some cases that

s/that$/where/, I think.

>  they can work together, and they were taught about this case.

s/this case/them/ ? Fixes "some cases"/"this case" mismatch, and avoids some duplication.

Show 10 quoted lines

> * en/fill-directory-exponential (2020-01-31) 6 commits
>  - t7063: blindly accept diffs
>  - dir: replace exponential algorithm with a linear one
>  - dir: refactor treat_directory to clarify control flow
>  - dir: fix confusion based on variable tense
>  - dir: fix broken comment
>  - dir: consolidate treat_path() and treat_one_path()
>
>  The directory traversal code had redundant recursive calls which
>  made its performance characteristics exponential wrt the depth of

s/wrt/with respect to/, perhaps.

>  the tree, which was corrected.

Martin