Re: [PATCH] getpriority: Only getpriority translation the priority values

From: Martin Ågren <martin.agren@gmail.com>
Date: May 14, 2022, 18:43 UTC
Message-ID: <CAN0heSper1O2ZdFq6RE=7znC0o+sFEsd8CBR3ckFtSoZu7Bzfw@mail.gmail.com>
In-Reply-To: <0fc70bd3-5883-47e4-1814-6ed6c756a400@gmail.com>

On Sat, 14 May 2022 at 17:11, Alejandro Colomar <alx.manpages@gmail.com> wrote:

Show 8 quoted lines

>
> BTW, I had to manually edit the patch.
> It's the second time I see this (I can't find the other one), your patch
> didn't apply for the following reason: the a/ and b/ prefixes in the
> file paths are missing.  Did you use git-format-patch(1) to produce the
> patch?  Can you reproduce this?
>
> I CCd the git mailing list in case they know what's going on.

Sounds like `git format-patch --no-prefix` at play. Or more likely, that the `diff.noprefix` config is on. I don't think it can be cancelled out by a `--no-no-prefix`, unfortunately. If a script is involved in running `git format-patch`, maybe it's not too tedious to make it do

  git -c diff.noprefix=no format-patch ...

to cancel the config. (If that config really does want to be on, that is.)

That said, something like

  git am -p0 ...

should help on the receiving side, by way of skipping fewer path components when applying the patch.

Martin