Re: [PATCH v2 3/3] mailinfo: disallow NUL character in mail's header

From: Martin Ågren <martin.agren@gmail.com>
Date: Apr 19, 2020, 12:30 UTC
Message-ID: <CAN0heSpZR6HtntK80DhQxtRQZo21GBd3uAKrsJxz_opyun8n4g@mail.gmail.com>
In-Reply-To: <cb96947b36b8ab314f5692daee6f627273ca66d3.1587289680.git.congdanhqx@gmail.com>

On Sun, 19 Apr 2020 at 13:05, Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

Show 15 quoted lines

> --- a/t/t4254-am-corrupt.sh
> +++ b/t/t4254-am-corrupt.sh
> @@ -69,9 +69,11 @@ test_expect_success "NUL in commit message's body" '
>         grep "a NUL byte in commit log message not allowed" err
>  '
>
> -test_expect_failure "NUL in commit message's header" '
> +test_expect_success "NUL in commit message's header" '
>         test_when_finished "git am --abort" &&
>         write_nul_patch subject >subject.patch &&
> +       test_must_fail git mailinfo msg patch <subject.patch 2>err &&
> +       grep "a NUL byte in Subject is not allowed" err &&
>         test_must_fail git am subject.patch 2>err &&
>         grep "a NUL byte in Subject is not allowed" err
>  '

We used to fail for some reason and it's sort of clear from the size of the test what that reason is. Now that we flip "failure" to "success" we can add some more stuff here that works. Makes sense. Of course, somewhere is a line for stuffing too much into the test, i.e., you'll reach a point where you should have separate tests, but I think this is ok.

Martin