Re: [PATCH v2 0/5] git-worktree documentation cleanups

From: Martin Ågren <martin.agren@gmail.com>
Date: Aug 4, 2020, 04:28 UTC
Message-ID: <CAN0heSpO4ocUTv2BSAOkRsuEX59V7phKn1=Y-PU2qq0POhp1Rg@mail.gmail.com>
In-Reply-To: <20200804005535.5126-1-sunshine@sunshineco.com>

On Tue, 4 Aug 2020 at 02:56, Eric Sunshine <sunshine@sunshineco.com> wrote:

>
> This is a re-roll of [1] which fixes some problems I ran across in the
> git-worktree documentation while working on another worktree-related
> topic.

Thanks for this update.

Show 6 quoted lines

> Eric Sunshine (5):
>   git-worktree.txt: employ fixed-width typeface consistently
>   git-worktree.txt: consistently use term "working tree"
>   git-worktree.txt: fix minor grammatical issues
>   git-worktree.txt: make start of new sentence more obvious
>   git-wortkree.txt: link to man pages when citing other Git commands

s/wortkree/worktree/ in the subject of the final, new patch.

I agree with all changes since v1, except ...

Show 5 quoted lines

>  CONFIGURATION FILE
>  ------------------
> -By default, the repository "config" file is shared across all working
> +By default, the repository `config` file is shared across all working
>  trees. If the config variables `core.bare` or `core.worktree` are

I don't think this is a filename (in which case it would have been `.gitconfig?) but rather some sort of colloquial short form for 'configuration file', thus '"config" file'. So I could see the double quotes remain or being dropped, but I was surprised to see them converted like this. But maybe you have a good reason, in which case I'm sure it's good.

Martin