Re: [PATCH 17/20] abbrev: unify the handling of empty values
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Jun 9, 2018, 14:31 UTC
- Message-ID
- <CAN0heSpMSmn=34ze4GmuETzR=VZ2TO4ooNC=PS+OM5yAawB3og@mail.gmail.com>
- In-Reply-To
- <CAN0heSqrgUw1u8Ykk-9eGosWwFS0NFM7sLBe5Loo4cN=tkrXaA@mail.gmail.com>
On 9 June 2018 at 16:24, Martin Ågren <martin.agren@gmail.com> wrote:
Show 10 quoted lines
> On 9 June 2018 at 00:41, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote: >> For no good reason the --abbrev= command-line option was less strict >> than the core.abbrev config option, which came down to the latter >> using git_config_int() which rejects an empty string, but the rest of >> the parsing using strtoul() which will convert it to 0. > > It will still be less strict in that it accepts trailing garbage, e.g., > `--abbrev=7a`. Probably ok to leave it at that in this series, but > possibly useful to mention here that this only makes these options "less > differently strict".
Hmpf, please ignore. That's what I get for looking at a few patches, taking a break, picking it up again and completely forgetting what's going on...