Re: [PATCH] config.txt: move closing "----" to cover entire listing

From: Martin Ågren <martin.agren@gmail.com>
Date: Apr 9, 2020, 15:00 UTC
Message-ID: <CAN0heSp3=8fTGb5Ciuvr8+EevNSrAfskvrrS_PN=VPhKJyB5jA@mail.gmail.com>
In-Reply-To: <20200409141452.GC3494212@coredump.intra.peff.net>

On Thu, 9 Apr 2020 at 16:14, Jeff King <peff@peff.net> wrote:

Show 6 quoted lines

>
> On Thu, Apr 09, 2020 at 12:35:41PM +0200, Martin Ågren wrote:
>
> >  Not sure how I managed to botch this in 1925fe0c8a.
>
> I managed to botch the review, as well. :)

:)

Show 5 quoted lines

> I checked it with doc-diff, but was surprised to find no change. That's
> because the manpage shows it the same either way (the indented chunk is
> just a different example, but two examples back to back render the same
> as a single one). But you can see the difference in the HTML version,
> where the final example isn't in the grey box.

Ah, you're using AsciiDoc. With Asciidoctor, there is a change in indentation of the "path = foo.inc" line with this new, proposed patch. The original commit reduced the number of occurrences of such AsciiDoc/tor differences around this spot, but failed to bring the number all the way down to zero. Now, finally, that discrepancy will be fixed.

Show 5 quoted lines

> That explains why I didn't see the issue when running doc-diff on the
> original bug. I wonder if we could teach doc-diff to look at the HTML,
> too. I'm not sure how, though. Certainly html2text or similar would get
> us something diff-able, but without the visual elements (like the grey
> box), I don't know that it's much more valuable than the manpages.

At one point I considered trying out diffoscope for this. It should allegedly be good at comparing "everything". But being good at everything, it wanted to pull in a discouragingly large number of dependencies, so I never actually tried it out. It doesn't explicitly claim to know html or manpages (but does mention xml and pdf), so I dunno.

Martin