Re: [PATCH 7/8] doc: improve asciidoc dependencies
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- May 13, 2021, 17:43 UTC
- Message-ID
- <CAN0heSoWPUvc+kQO2oXx1XnpOp7=jesGJ80XZm6EjTe15RxQLQ@mail.gmail.com>
- In-Reply-To
- <20210512222803.508446-8-felipe.contreras@gmail.com>
On Thu, 13 May 2021 at 00:28, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > asciidoc needs asciidoc.conf, asciidoctor asciidoctor-extensions.rb. > > Neither needs the other.
> -ASCIIDOC_DEPS = asciidoc.conf asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS > +ASCIIDOC_DEPS = asciidoc.conf GIT-ASCIIDOCFLAGS
> +ASCIIDOC_DEPS = asciidoctor-extensions.rb GIT-ASCIIDOCFLAGS
Thanks. I was a bit lazy in a15ef383e7 ("Documentation/Makefile: add missing dependency on asciidoctor-extensions", 2019-02-27).
We end up with some duplication. We could pull GIT-ASCIIDOCFLAGS into some ASCIIDOC_DEPS_COMMON. But with just one such common dependency, it seems unnecessary and overly complicated. We can pull out the common dependencies when we actually gain something from it.
Martin