Re: [PATCH] stripspace: allow -s/-c outside git repository

From: Martin Ågren <martin.agren@gmail.com>
Date: Dec 19, 2018, 21:52 UTC
Message-ID: <CAN0heSoUu-d1vut+5S_Sb8kASiFTG0mGfPqMzbXKxAQFr1JfKg@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1812181258550.43@tvgsbejvaqbjf.bet>

On Tue, 18 Dec 2018 at 13:00, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 9 quoted lines

> > Makes me wonder if `setup_git_directory_gently()` should BUG if it
> > receives NULL. That would require some reshuffling in setup.c, since
> > `setup_git_directory()` calls out to it with NULL... Just thinking out
> > loud. In any case, and more importantly, this is the last user providing
> > NULL except for the one in `setup_git_directory()`.
>
> We could rename `setup_git_directory_gently()` to
> `setup_git_directory_gently_2()`, make that `static` and then call it from
> `setup_git_directory_gently()` and `setup_git_directory()`.

Thanks for the hint. I'm currently recuperating from having been lost in a nearby corner of setup.c, so I´ll leave this tightening as a low-hanging fruit for "someone else."

Martin