Re: [PATCH] xdiff: reduce indent heuristic overhead
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jul 3, 2018, 09:15 UTC
- Message-ID
- <CAMy9T_HUdszkq8c545puzCpjvh1pKAL7MWtnrZFagNndyyxK7A@mail.gmail.com>
- In-Reply-To
- <CAGZ79kZzrdswds4ejCJrhJD1UcJeODdhifX5-UREuK5wPUM-rg@mail.gmail.com>
On Mon, Jul 2, 2018 at 7:27 PM Stefan Beller <sbeller@google.com> wrote:
> On Sun, Jul 1, 2018 at 8:57 AM Michael Haggerty <mhagger@alum.mit.edu> wrote: > [...] > So this suggests to have MAX_BORING to be > "hunk size + some small constant offset" ?
That would be my suggestion, yes. There are cases where it will be more expensive than a fixed `MAX_BORING`, but I bet on average it will be faster. Plus, it should always give the right answer.
Michael