git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] Fix misuses of "nor" in comments. (v3)

From
Justin Lebar <jlebar@google.com>
Date
Mar 31, 2014, 21:04 UTC
Message-ID
<CAMuNMfpnojdQi4x_M_k29GBsq_i282Zph3AgLgsZv4arxB3CfA@mail.gmail.com>
In-Reply-To
<CAEjxke9pe23YAc_D-JmAd+HkgocNuTrwQxSkGS7DaJhgw9GMRg@mail.gmail.com>
Thanks; fixed in v4 (just sent out).
On Mon, Mar 31, 2014 at 12:54 PM, Jason St. John <jstjohn@purdue.edu> wrote:
Show 51 quoted lines
> On Sat, Mar 29, 2014 at 6:59 PM, Justin Lebar <jlebar@google.com> wrote:
>> This version applies successfully to master, maint, next, and pu.  The other
>> patches in the previous version of this queue apply successfully without any
>> changes.
>>
>> Signed-off-by: Justin Lebar <jlebar@google.com>
>>
>> ---
>>  Makefile                                    | 2 +-
>>  builtin/apply.c                             | 2 +-
>>  builtin/checkout.c                          | 2 +-
>>  builtin/log.c                               | 2 +-
>>  builtin/pack-objects.c                      | 2 +-
>>  column.c                                    | 4 ++--
>>  contrib/examples/git-checkout.sh            | 2 +-
>>  contrib/examples/git-reset.sh               | 4 ++--
>>  contrib/fast-import/import-directories.perl | 4 ++--
>>  delta.h                                     | 2 +-
>>  diff.c                                      | 2 +-
>>  git-am.sh                                   | 2 +-
>>  gitweb/gitweb.perl                          | 2 +-
>>  http.h                                      | 4 ++--
>>  perl/Git/SVN.pm                             | 2 +-
>>  perl/Git/SVN/Migration.pm                   | 2 +-
>>  pkt-line.h                                  | 8 ++++----
>>  remote.c                                    | 2 +-
>>  sha1_file.c                                 | 2 +-
>>  test-chmtime.c                              | 2 +-
>>  20 files changed, 27 insertions(+), 27 deletions(-)
>>
>
> <snip>
>
>> diff --git a/http.h b/http.h
>> index cd37d58..0a7d286 100644
>> --- a/http.h
>> +++ b/http.h
>> @@ -13,8 +13,8 @@
>>  /*
>>   * We detect based on the cURL version if multi-transfer is
>>   * usable in this implementation and define this symbol accordingly.
>> - * This is not something Makefile should set nor users should pass
>> - * via CFLAGS.
>> + * This shouldn't be be set by the Makefile or by the user (e.g. via
>> + * CFLAGS).
>>   */
>>  #undef USE_CURL_MULTI
>
> There's a rather minor typo here: "be be"
>
> Jason
Previous: Jason St. JohnNext: Junio C Hamano
Message 3 of 4 in “Fix misuses of "nor" in comments. (v3)”
  1. 3/4 Fix misuses of "nor" in comments. (v3)Justin Lebar, Mar 29, 2014
  2. Jason St. JohnMar 31, 2014
  3. Justin LebarMar 31, 2014
  4. Junio C HamanoMar 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.