Re: [PATCH] t7300: fix broken && chains

From: erik elfström <erik.elfstrom@gmail.com>
Date: Sep 1, 2015, 06:31 UTC
Message-ID: <CAMpP7NZMMYyCbmnzhLTqa73TD_mqk+rO8=D0v9qb0z_UmBQ-rg@mail.gmail.com>
In-Reply-To: <xmqqzj17wg1i.fsf@gitster.mtv.corp.google.com>

On Mon, Aug 31, 2015 at 6:58 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>
> Many of the constructs we see here shows clearly that this is an
> ancient part of the codebase ;-), as we would be using the one
> parameter form of "git init" and more test_* helpers if we were
> writing this script in today's Git codebase.  It may have been
> better if you didn't do "while we are here" and corrected only the
> &&-chain in patch 1/2 and then updated the style of the tests to
> take advantage of the newer facilities recent test-lib has in a
> separate patch 2/2, but this will do at least for now.
>
> Will queue.
>
> Thanks.

I can do a re-roll with the chain fix in the first patch and a more thorough modernization of t7300 in separate patches if you'd like? I almost went this way for v1 but decided to limit the scope for the first version.

(Forgot to include the list in my first reply, sorry... And forgot to turn off HTML in the second... sigh, sorry for the spam)

/Erik