git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] trailer: spread usage of "trailer_block" language

From
LALinus Arver <linus@ucla.edu>
Date
Nov 12, 2024, 10:49 UTC
Message-ID
<CAMo6p=GOjmUQWHE9QH0wUY=FCzN4-mjknryWRbp4dQW4MFthqw@mail.gmail.com>
In-Reply-To
<xmqq34jx8adx.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Linus Arver <linusa@google.com>
>>
>> Deprecate the "trailer_info" struct name and replace it with
>> "trailer_block". This is more readable, for two reasons:
>>
>>   1. "trailer_info" on the surface sounds like it's about a single
>>      trailer when in reality it is a collection of one or more trailers,
>>      and
>>
>>   2. the "*_block" suffix is more informative than "*_info", because it
>>      describes a block (or region) of contiguous text which has trailers
>>      in it, which has been parsed into the trailer_block structure.
>>
>> Rename the
>>
>>     size_t trailer_block_start, trailer_block_end;
>>
>> members of trailer_info to just "start" and "end". Rename the "info"
>> pointer to "trailer_block" because it is more descriptive. Update
>> comments accordingly.
>
> All makes sense.  Often "_info" suffix has very low information
> density, as everything is "info" in a sense ;-)
Exactly.
> Will merge to 'next' (unless there is a belated "it may not break,
> but it is not a good idea because ...", that is).
Yup, sounds good. Thanks!
Previous: Junio C Hamano
Message 7 of 7 in “trailer: spread usage of "trailer_block" language”
  1. trailer: spread usage of "trailer_block" languageLinus Arver via GitGitGadget, Oct 13, 2024
  2. Linus ArverOct 15, 2024
  3. Taylor BlauOct 15, 2024
  4. Johannes SchindelinNov 5, 2024
  5. Linus ArverNov 12, 2024
  6. Junio C HamanoNov 12, 2024
  7. Linus ArverNov 12, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.